-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final fix for Commit Checker GH Action #50
Final fix for Commit Checker GH Action #50
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Commit Checker results:
commitchecker verson unknown |
@@ -6,8 +6,6 @@ on: | |||
- completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpick but version
and commit checker
are spelled incorrectly in the commit checker error message: rimolive#2 (comment)
could you add that fix as part of this PR?
A set of new images have been built to help with testing out this PR: |
An OCP cluster where you are logged in as cluster admin is required. The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO. To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
name: pr-50
spec:
dspVersion: v2
apiServer:
image: "quay.io/opendatahub/ds-pipelines-api-server:pr-50"
argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-50"
argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-50"
persistenceAgent:
image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-50"
scheduledWorkflow:
image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-50"
mlmd:
deploy: true # Optional component
grpc:
image: "quay.io/opendatahub/mlmd-grpc-server:latest"
envoy:
image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
mlpipelineUI:
deploy: true # Optional component
image: "quay.io/opendatahub/ds-pipelines-frontend:pr-50"
objectStorage:
minio:
deploy: true
image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance' Then run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/50/head
git checkout -b pullrequest fbb2c121655f10f366449febcdf8f669c4204a88
oc apply -f dspa.pr-50.yaml More instructions here on how to deploy and test a Data Science Pipelines Application. |
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
fbb2c12
to
dcbeed8
Compare
New changes are detected. LGTM label has been removed. |
Commit Checker results:
commitchecker verson unknown |
Change to PR detected. A new PR build was completed. |
Commit Checker results:
|
Description of your changes:
Fixes the Commit Checker GitHub Action to checkout the PR branch before running the check.
Checklist: